This is an automated email from the ASF dual-hosted git repository.

mmarshall pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-2.10 by this push:
     new fd700dafe27 [fix][io] Update Elasticsearch sink idle cnx timeout to 
30s (#19377)
fd700dafe27 is described below

commit fd700dafe27c6e3f5efa57dcd3148f99c0a81672
Author: Michael Marshall <[email protected]>
AuthorDate: Tue Jan 31 15:35:49 2023 -0600

    [fix][io] Update Elasticsearch sink idle cnx timeout to 30s (#19377)
    
    (cherry picked from commit 1481c7480ec586bb63d2efec711b2379683d5cba)
---
 .../org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java     | 1 -
 .../org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java     | 6 +++---
 .../apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java    | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
 
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
index 25c06880e15..a4cce0877c7 100644
--- 
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
+++ 
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
@@ -193,7 +193,6 @@ public class ElasticSearchClient implements AutoCloseable {
         // idle+expired connection evictor thread
         this.executorService = Executors.newSingleThreadScheduledExecutor();
         this.executorService.scheduleAtFixedRate(() -> {
-            configCallback.connectionManager.closeExpiredConnections();
             configCallback.connectionManager.closeIdleConnections(
                     config.getConnectionIdleTimeoutInMs(), 
TimeUnit.MILLISECONDS);
         },
diff --git 
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
 
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
index 44cdee9553a..95ac9ffdc8e 100644
--- 
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
+++ 
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
@@ -196,10 +196,10 @@ public class ElasticSearchConfig implements Serializable {
 
     @FieldDoc(
             required = false,
-            defaultValue = "5",
-            help = "Idle connection timeout to prevent a read timeout."
+            defaultValue = "30000",
+            help = "Idle connection timeout to prevent a connection timeout 
due to inactivity."
     )
-    private int connectionIdleTimeoutInMs = 5;
+    private int connectionIdleTimeoutInMs = 30000;
 
     @FieldDoc(
             required = false,
diff --git 
a/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
 
b/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
index 2270349ee83..c675f3ace34 100644
--- 
a/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
+++ 
b/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
@@ -86,7 +86,7 @@ public class ElasticSearchConfigTests {
         assertEquals(config.isCompressionEnabled(), false);
         assertEquals(config.getConnectTimeoutInMs(), 5000L);
         assertEquals(config.getConnectionRequestTimeoutInMs(), 1000L);
-        assertEquals(config.getConnectionIdleTimeoutInMs(), 5L);
+        assertEquals(config.getConnectionIdleTimeoutInMs(), 30000L);
         assertEquals(config.getSocketTimeoutInMs(), 60000);
 
         assertEquals(config.isStripNulls(), true);

Reply via email to