This is an automated email from the ASF dual-hosted git repository.
mmarshall pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.9 by this push:
new 5265cb8c464 [fix][io] Update Elasticsearch sink idle cnx timeout to
30s (#19377)
5265cb8c464 is described below
commit 5265cb8c464fbe7a40446dfa08c901c7a4981a8f
Author: Michael Marshall <[email protected]>
AuthorDate: Tue Jan 31 15:35:49 2023 -0600
[fix][io] Update Elasticsearch sink idle cnx timeout to 30s (#19377)
(cherry picked from commit 1481c7480ec586bb63d2efec711b2379683d5cba)
(cherry picked from commit fd700dafe27c6e3f5efa57dcd3148f99c0a81672)
---
.../org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java | 1 -
.../org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java | 6 +++---
.../apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
index b9e756e24d3..c298789f4ee 100644
---
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
+++
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
@@ -188,7 +188,6 @@ public class ElasticSearchClient implements AutoCloseable {
this.executorService.scheduleAtFixedRate(new Runnable() {
@Override
public void run() {
-
configCallback.connectionManager.closeExpiredConnections();
configCallback.connectionManager.closeIdleConnections(
config.getConnectionIdleTimeoutInMs(), TimeUnit.MILLISECONDS);
}
diff --git
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
index dc6d0d415a0..ee06c2dd284 100644
---
a/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
+++
b/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
@@ -193,10 +193,10 @@ public class ElasticSearchConfig implements Serializable {
@FieldDoc(
required = false,
- defaultValue = "5",
- help = "Idle connection timeout to prevent a read timeout."
+ defaultValue = "30000",
+ help = "Idle connection timeout to prevent a connection timeout
due to inactivity."
)
- private int connectionIdleTimeoutInMs = 5;
+ private int connectionIdleTimeoutInMs = 30000;
@FieldDoc(
required = false,
diff --git
a/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
b/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
index 2270349ee83..c675f3ace34 100644
---
a/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
+++
b/pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfigTests.java
@@ -86,7 +86,7 @@ public class ElasticSearchConfigTests {
assertEquals(config.isCompressionEnabled(), false);
assertEquals(config.getConnectTimeoutInMs(), 5000L);
assertEquals(config.getConnectionRequestTimeoutInMs(), 1000L);
- assertEquals(config.getConnectionIdleTimeoutInMs(), 5L);
+ assertEquals(config.getConnectionIdleTimeoutInMs(), 30000L);
assertEquals(config.getSocketTimeoutInMs(), 60000);
assertEquals(config.isStripNulls(), true);