Demogorgon314 commented on code in PR #183:
URL: https://github.com/apache/pulsar-client-cpp/pull/183#discussion_r1095390218
##########
wireshark/CMakeLists.txt:
##########
@@ -17,67 +17,46 @@
# under the License.
#
-set(CMAKE_CXX_FLAGS "-O3 -g ${CMAKE_CXX_FLAGS}")
+cmake_minimum_required(VERSION 3.7)
+project(pulsar-cpp-wireshark)
-MESSAGE(STATUS "Use WIRESHARK_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
+set(CMAKE_CXX_STANDARD 11)
Review Comment:
The command should move in this line. Otherwise, it will use `#include
<config.h>` by default, so when using a high version of Wireshark dependency
will fail when built.
```
➜ wireshark git:(bewaremypower/wireshark-fix) ✗ cmake --build build
[ 25%] Running cpp protocol buffer compiler on
/Users/wangkai/Developer/github/pulsar-client-cpp/wireshark/../proto/PulsarApi.proto
[ 50%] Building CXX object
CMakeFiles/pulsar-dissector.dir/pulsarDissector.cc.o
/Users/wangkai/Developer/github/pulsar-client-cpp/wireshark/pulsarDissector.cc:24:10:
fatal error: 'config.h' file not found
#include <config.h>
^~~~~~~~~~
1 error generated.
gmake[2]: *** [CMakeFiles/pulsar-dissector.dir/build.make:84:
CMakeFiles/pulsar-dissector.dir/pulsarDissector.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/pulsar-dissector.dir/all]
Error 2
gmake: *** [Makefile:91: all] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
