mattisonchao commented on code in PR #19444:
URL: https://github.com/apache/pulsar/pull/19444#discussion_r1099429975
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -1650,8 +1656,15 @@ void createNewOpAddEntryForNewLedger() {
} while (existsOp != null && --pendingSize > 0);
}
- protected synchronized void updateLedgersIdsComplete() {
+ protected synchronized void updateLedgersIdsComplete(@Nullable
LedgerHandle originalCurrentLedger) {
STATE_UPDATER.set(this, State.LedgerOpened);
+ // Delete original "currentLedger" if it has been removed from
"ledgers".
+ if (originalCurrentLedger != null &&
!ledgers.containsKey(originalCurrentLedger.getId())){
+ bookKeeper.asyncDeleteLedger(originalCurrentLedger.getId(), (rc,
ctx) -> {
+ mbean.endDataLedgerDeleteOp();
+ log.info("[{}] Delete complete for empty ledger {}. rc={}",
name, originalCurrentLedger.getId(), rc);
Review Comment:
Why do we call this an empty ledger? Should we give a warn log when delete
fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
