BewareMyPower commented on PR #187: URL: https://github.com/apache/pulsar-client-cpp/pull/187#issuecomment-1423611379
This fix LGTM. But I still think the lock for `ProducerImpl::handleCreateProducer` introduced in https://github.com/apache/pulsar-client-cpp/pull/131 is dangerous. We should avoid acquiring the mutex in any callback, which could be called in the caller's thread and might lead to a deadlock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
