shibd commented on PR #187: URL: https://github.com/apache/pulsar-client-cpp/pull/187#issuecomment-1423671441
Although this modification avoids deadlocks, I would like to discuss some implementation details. 1. When P3 started failed, why need close all producers? Wouldn't it be better for other functioning producers to send messages? (Suppose P3 is temporarily unavailable due to load balancing) 2. Other question: When partitions are changed, we can't guarantee that the same key is sent to the same parition-topic, right? (RoundRobinMode) `topicMetadata.getNumPartitions()` has changed, The result is different. https://github.com/apache/pulsar-client-cpp/blob/872f8abaade7ecd346d3f59e2f6b3901c65ef7de/lib/RoundRobinMessageRouter.cc#L53-L57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
