nodece commented on code in PR #19483:
URL: https://github.com/apache/pulsar/pull/19483#discussion_r1105423649
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java:
##########
@@ -159,8 +159,10 @@ public SSLContext createSSLContext() throws
GeneralSecurityException, IOExceptio
: TrustManagerFactory.getInstance(tmfAlgorithm);
KeyStore trustStore = KeyStore.getInstance(trustStoreTypeString);
char[] passwordChars = trustStorePassword.toCharArray();
- try (FileInputStream inputStream = new
FileInputStream(trustStorePath)) {
- trustStore.load(inputStream, passwordChars);
+ if (!Strings.isNullOrEmpty(trustStorePath)) {
Review Comment:
> What is the implication of an empty value resulting in skipping the load
here?
When we use the certificate from the public CA, we don't need to set up the
trust store.
I can add `log.debug` here.
> Should we document the relevant configurations to describe this behavior?
No documentation, we should add this note to our documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
