michaeljmarshall commented on code in PR #19483:
URL: https://github.com/apache/pulsar/pull/19483#discussion_r1107622646
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java:
##########
@@ -159,8 +159,10 @@ public SSLContext createSSLContext() throws
GeneralSecurityException, IOExceptio
: TrustManagerFactory.getInstance(tmfAlgorithm);
KeyStore trustStore = KeyStore.getInstance(trustStoreTypeString);
char[] passwordChars = trustStorePassword.toCharArray();
- try (FileInputStream inputStream = new
FileInputStream(trustStorePath)) {
- trustStore.load(inputStream, passwordChars);
+ if (!Strings.isNullOrEmpty(trustStorePath)) {
Review Comment:
Based on quickly reading through the code for conscrypt, I am wondering if
this PR will work as described. Have you tested it? I see the following code in
conscrypt:
```
public void engineInit(KeyStore ks) throws KeyStoreException {
if (ks != null) {
keyStore = ks;
} else {
keyStore = Platform.getDefaultCertKeyStore();
}
}
```
That indicates to me that we should pass `null` to the
`trustManagerFactory.init(trustStore);` instead of passing a created but not
yet initialized `trustStore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
