315157973 commented on code in PR #19560:
URL: https://github.com/apache/pulsar/pull/19560#discussion_r1112902895
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:
##########
@@ -233,5 +237,23 @@ private Pair<Boolean, String> getMaxUsageBroker(
}
return Pair.of(hasBrokerBelowLowerBound, maxUsageBrokerName);
}
+ @Override
+ public void onBrokerChange(Set<String> newBrokers) {
+ synchronized (activeBrokers) {
+ activeBrokers.clear();
+ activeBrokers.addAll(newBrokers);
+ }
+ }
+
+ private void cleanUnActiveBroker() {
+ if (!activeBrokers.isEmpty()) {
+ synchronized (activeBrokers) {
+ if (!activeBrokers.isEmpty()) {
+ brokerAvgResourceUsage.keySet().removeIf((key) ->
!activeBrokers.contains(key));
Review Comment:
> Can we clean this map in the onBrokerChange method?
If we clean the map in `onBrokerChange`，we have to lock every time, but now
we don't need to lock every time
> Also, we can use keySet().retainAll(activeBrokers) to get Intersection.
We don't want to clean up the inactive Broker every time, because it needs
to be locked.
If we don't clear this collection, we have to lock it every time to judge
whether it needs to be cleaned up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
