315157973 commented on code in PR #19560:
URL: https://github.com/apache/pulsar/pull/19560#discussion_r1112998837
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:
##########
@@ -233,5 +237,23 @@ private Pair<Boolean, String> getMaxUsageBroker(
}
return Pair.of(hasBrokerBelowLowerBound, maxUsageBrokerName);
}
+ @Override
+ public void onBrokerChange(Set<String> newBrokers) {
+ synchronized (activeBrokers) {
+ activeBrokers.clear();
+ activeBrokers.addAll(newBrokers);
+ }
+ }
+
+ private void cleanUnActiveBroker() {
+ if (!activeBrokers.isEmpty()) {
+ synchronized (activeBrokers) {
+ if (!activeBrokers.isEmpty()) {
+ brokerAvgResourceUsage.keySet().removeIf((key) ->
!activeBrokers.contains(key));
Review Comment:
In this way, the place where `brokerAvgResourceUsage` is used in
`findBundlesForUnloading` must be locked, that is, it must be locked every
time, because now `brokerAvgResourceUsage` will be called in the
`updateAvgResourceUsage` method every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
