michaeljmarshall commented on code in PR #19540:
URL: https://github.com/apache/pulsar/pull/19540#discussion_r1113585241
##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java:
##########
@@ -66,7 +65,7 @@ protected ByteBuf newConnectCommand() throws Exception {
authenticationDataProvider =
authentication.getAuthData(remoteHostName);
AuthData authData =
authenticationDataProvider.authenticate(AuthData.INIT_AUTH_DATA);
return Commands.newConnect(authentication.getAuthMethodName(),
authData, protocolVersion,
- PulsarVersion.getVersion(), proxyToTargetBrokerAddress,
clientAuthRole, clientAuthData,
+ proxyConnection.clientVersion, proxyToTargetBrokerAddress,
clientAuthRole, clientAuthData,
Review Comment:
Yes, I am familiar with the difference for the protocol and the client
version. However, it seems debatable to me which client version is connected
here because the proxy is re-writing all requests instead of just forwarding
them. For the purpose of troubleshooting, it seems valuable to know that the
proxy is in the middle for these lookup connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
