RobertIndie commented on PR #19540: URL: https://github.com/apache/pulsar/pull/19540#issuecomment-1441417476
@michaeljmarshall > Ultimately, the question is how should the client_version field be used? Is it for users or administrators? I can see the argument for end users not needing to know the proxy is in the middle, but I can also see an argument for operators wanting to know that the client connected through the proxy and to know which version of the proxy is connected. It is very relevant auditing information. I get your points now. From [the document](https://pulsar.apache.org/docs/next/administration-stats/#topic-stats) : > clientVersion is The client library version of this producer/consumer. I think the `client_version` should be literally represented as the client version but not the proxy version. And let's add a new field called `proxy version` as you just proposed. This way, the user does not need to bother whether the client Version refers to the directly connected client(which may be the proxy) or the proxied client. The end user could get it from `client_version` and the operators could get it from `proxy_version`. According to the document above, I think this PR is still a bug fix. Getting the clientVersion from a proxy is not worked before this PR, therefore, this PR doesn't change the existing behavior. From my understanding, this PR is good to go. I would like to propose a new PIP to add such a feature because it will change the protocol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
