Anonymitaet commented on code in PR #412: URL: https://github.com/apache/pulsar-site/pull/412#discussion_r1113751246
########## docs/cookbooks-retention-expiry.md: ########## @@ -473,3 +479,6 @@ The diagram below illustrates one of the cases that the consumed storage size is  If you do not have any retention period and you never have much of a backlog, the upper limit for retained messages, which are acknowledged, equals the Pulsar segment rollover period + entry log rollover period + (garbage collection interval * garbage collection ratios). + +[backlogquotacheckintervalinseconds]: https://pulsar.apache.org/reference/#/next/config/reference-configuration-broker?id=backlogquotacheckintervalinseconds +[precisetimebasedbacklogquotacheck]: https://pulsar.apache.org/reference/#/next/config/reference-configuration-broker?id=precisetimebasedbacklogquotacheck Review Comment: 1. What's the context of these two paras? Do you intend mean this? ```suggestion To configure checks, you can use `backlogquotacheckintervalinseconds` and `precisetimebasedbacklogquotacheck` parameters. Details see **Configuration > Plusar > Broker** on [Pulsar Reference Site](https://pulsar.apache.org/reference). ``` 2. Suggest using general link (https://pulsar.apache.org/reference) instead of specific links to reduce maintenance costs and potential errors. We've applied this strategy across all docs. ########## docs/cookbooks-retention-expiry.md: ########## @@ -214,6 +214,12 @@ Backlog quotas are handled at the namespace level. They can be managed via: You can set a size and/or time threshold and backlog retention policy for all of the topics in a [namespace](reference-terminology.md#namespace) by specifying the namespace, a size limit and/or a time limit in second, and a policy by name. +::: note + +By default, time-based backlogs are enforced periodically using an approximate method. This avoids a potentially costly scan of the backlog each time a message is produced. However, it does mean that in some cases you may observe a lack of strict enforcement. To tune this behavior, you should consider using the [`backlogQuotaCheckIntervalInSeconds`][backlogquotacheckintervalinseconds] and [`preciseTimeBasedBacklogQuotaCheck`][precisetimebasedbacklogquotacheck] broker options. Review Comment: what does this mean? > [`xxx`][xxx] <img width="733" alt="image" src="https://user-images.githubusercontent.com/50226895/220500831-bbca54e4-1568-4416-970f-e4986148aaec.png";> Do you want to highlight the para? You can use `xxx` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/50226895/220500831-bbca54e4-1568-4416-970f-e4986148aaec.png"](https://user-images.githubusercontent.com/50226895/220500831-bbca54e4-1568-4416-970f-e4986148aaec.png"){kind=link}