RobertIndie opened a new pull request, #206:
URL: https://github.com/apache/pulsar-client-cpp/pull/206
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
### Motivation
Currently, the `client_version ` only shows the version information. And
clients in different languages use their own separate version numbers. This can
lead to conflict. For example, the java client 2.10.2 uses the same value
`2.10.2` as the C++ client 2.10.2. And C++ client 3.0.0 may conflict with the
future java client 3.0.0. The information of `client_version` is incomplete. We
could not determine what language(or specific library) the client uses. This
raises inconvenience for debugging.
This PR adopts a new client version format for the C++ client.
Please see the discussion:
https://lists.apache.org/thread/n59k537fhthjnzkfxtc2p4zk4l0cv3mp
### Modifications
* Change the client version value to `Pulsar-C++-vXXX`
<!-- Describe the modifications you've done. -->
### Verifying this change
This change added tests.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
