RobertIndie commented on code in PR #206:
URL: https://github.com/apache/pulsar-client-cpp/pull/206#discussion_r1121090689
##########
lib/Commands.cc:
##########
@@ -266,7 +266,7 @@ SharedBuffer Commands::newConnect(const AuthenticationPtr&
authentication, const
BaseCommand cmd;
cmd.set_type(BaseCommand::CONNECT);
CommandConnect* connect = cmd.mutable_connect();
- connect->set_client_version(PULSAR_VERSION_STR);
+ connect->set_client_version(std::string("Pulsar-C++-v") +
PULSAR_VERSION_STR);
Review Comment:
Oh. I see that we are already using CPP here:
https://github.com/apache/pulsar-client-cpp/blob/05807bdaf3a4341b22efd7c71f7b00c47cc31413/lib/HTTPLookupService.cc#L195
+1 for using CPP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
