urfreespace commented on code in PR #439:
URL: https://github.com/apache/pulsar-site/pull/439#discussion_r1119644067
##########
src/utils/index.js:
##########
@@ -54,10 +54,14 @@ export function setVersion(version) {
}
export function getVersion() {
- if (/version=(\d+\.?\x?)+/.test(location.href)) {
- return location.href.match(/version=(\d+\.?\x?)+/)[0];
+ try {
+ if (/version=(\d+\.?\x?)+/.test(location.href)) {
+ return location.href.match(/version=((\d+\.?\x?)+)/)[1];
+ }
Review Comment:
> Is it possible we find the query part version=...&apiversion=.. and match
the version key-value pair exactly? Instead of using regexp which is brittle.
NO, need to parse the query string yourself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
