tisonkun commented on code in PR #439:
URL: https://github.com/apache/pulsar-site/pull/439#discussion_r1119752768
##########
src/utils/index.js:
##########
@@ -54,10 +54,14 @@ export function setVersion(version) {
}
export function getVersion() {
- if (/version=(\d+\.?\x?)+/.test(location.href)) {
- return location.href.match(/version=(\d+\.?\x?)+/)[0];
+ try {
+ if (/version=(\d+\.?\x?)+/.test(location.href)) {
+ return location.href.match(/version=((\d+\.?\x?)+)/)[1];
+ }
Review Comment:
OK. I may suggest to use `version=([0-9.x]+)` for comprehension. You can
test it locally.
But +1 to merge as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
