poorbarcode commented on code in PR #19667:
URL: https://github.com/apache/pulsar/pull/19667#discussion_r1122856200
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2182,8 +2182,8 @@ protected void
handleGetTopicsOfNamespace(CommandGetTopicsOfNamespace commandGet
getBrokerService().pulsar().getNamespaceService().getListOfTopics(namespaceName,
mode)
.thenAccept(topics -> {
boolean filterTopics = false;
- // filter transaction internal topic
- List<String> filteredTopics =
TopicList.filterTransactionInternalName(topics);
+ // filter system topic
+ List<String> filteredTopics =
TopicList.filterSystemTopic(topics);
Review Comment:
>> Hi @shibd
>> These system topics are defined by
https://github.com/apache/pulsar/issues/16042. Could we only filter out these
topics instead of all system topics?
>> Hi @liangyepianzhou
>> Could you review this PR?
> Why? I think we should filter all system topics, these topics should be
invisible to the user.
The original implementation only filters out topics of type TXN, system
topics have other type topics, which would be a break change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
