poorbarcode commented on code in PR #19667:
URL: https://github.com/apache/pulsar/pull/19667#discussion_r1123207726
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2182,8 +2182,8 @@ protected void
handleGetTopicsOfNamespace(CommandGetTopicsOfNamespace commandGet
getBrokerService().pulsar().getNamespaceService().getListOfTopics(namespaceName,
mode)
.thenAccept(topics -> {
boolean filterTopics = false;
- // filter transaction internal topic
- List<String> filteredTopics =
TopicList.filterTransactionInternalName(topics);
+ // filter system topic
+ List<String> filteredTopics =
TopicList.filterSystemTopic(topics);
Review Comment:
> These system themes are all used internally(__change_event and
transaction-related topics), and I don't think they should be exposed to users.
I think so too. But before we filter out all the system topics, should we
send an email to discuss it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
