nodece opened a new pull request, #19762: URL: https://github.com/apache/pulsar/pull/19762
### Motivation In creating the cluster, when the `serviceUrlTls` is empty in the `ClusterData`, I got `Illegal service tls url, example: https://pulsar.example.com:8443`. I expect the Pulsar works fine. #19151 breaks this behavior, see the following code: ``` public static void checkURIIfPresent(@Nullable String uri, @Nonnull Predicate<URI> predicate, @Nullable String errorMessage) throws IllegalArgumentException { if (uri == null) { return; } checkURI(uri, predicate, errorMessage); } ``` This check should also ignore the empty URL. ### Modifications - Ignore checking the empty URL ### Verifying this change - [x] Make sure that the change passes the CI checks. Added `testCreateCluster` test. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
