michaeljmarshall commented on code in PR #19762:
URL: https://github.com/apache/pulsar/pull/19762#discussion_r1142527008
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/URIPreconditions.java:
##########
@@ -67,7 +67,7 @@ public static void checkURIIfPresent(@Nullable String uri,
public static void checkURIIfPresent(@Nullable String uri,
@Nonnull Predicate<URI> predicate,
@Nullable String errorMessage) throws
IllegalArgumentException {
- if (uri == null) {
+ if (uri == null || uri.length() == 0) {
Review Comment:
I created https://github.com/apache/pulsar/issues/19866.
Also, while looking into it, I realized that this PR didn't introduce the
possibility of configuring no urls. The issue I created is very low priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
