Gleiphir2769 commented on code in PR #991:
URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r1145595299
##########
pulsar/consumer_partition.go:
##########
@@ -333,6 +335,7 @@ func newPartitionConsumer(parent Consumer, client *client,
options *partitionCon
}
if pc.options.autoReceiverQueueSize {
pc.currentQueueSize.Store(initialReceiverQueueSize)
+
pc.client.memLimit.RegisterTrigger(receiverQueueShrinkMemThreshold,
pc.shrinkReceiverQueueSize)
Review Comment:
But `memory_limit_controller` is created by client. If threshold is managed
by `memory_limit_controller`, will the threshold become a magic number?
I'm not sure if my thinking is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
