shibd commented on code in PR #991:
URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r1145631152


##########
pulsar/consumer_partition.go:
##########
@@ -333,6 +335,7 @@ func newPartitionConsumer(parent Consumer, client *client, 
options *partitionCon
        }
        if pc.options.autoReceiverQueueSize {
                pc.currentQueueSize.Store(initialReceiverQueueSize)
+               
pc.client.memLimit.RegisterTrigger(receiverQueueShrinkMemThreshold, 
pc.shrinkReceiverQueueSize)

Review Comment:
   I think it can be passed in via the constructor(`NewMemoryLimitController`).
   
   In the short, We don't have to set a threshold for each trigger, it should 
be unique in `memory_limit_controller`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to