niharrathod opened a new pull request, #19965: URL: https://github.com/apache/pulsar/pull/19965
Fixes #19866 ### Motivation Verify either TlsUrl or nonTlsUrl is provided as part of Cluster create and update operation. This validation is not applicable for "global" cluster create / update operation. ### Modifications - Added validation either serviceUrl or serviceUrlTls is set as part of cluster creation and update API. - Added validation either brokerServiceUrl or brokerServiceUrlTls is set as part of cluster creation and update API. - Added unit test cases. - Fixed old test-cases. Core changes are only in two files ClusterBases.java, ClusterDataImpl.java, added unit test w.r.t same in ClusterDataTest.java rest 115 file diff is because of patching existing test cases. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change added can be verified as follows: - unit tests added - fixed old test cases ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [X] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
