niharrathod commented on PR #19965: URL: https://github.com/apache/pulsar/pull/19965#issuecomment-1492823437
At first site this looks big change, but actual changes are only in two files [ClustersBase.java](https://github.com/apache/pulsar/pull/19965/files#diff-714966d12f914572a5ac289654f21efbf6ef1ae0f35ba1876179fd645961ced6), [ClusterDataImpl.java](https://github.com/apache/pulsar/pull/19965/files#diff-d7836029dc49b4e9f42bb0ee927c538f31d15e0ce64fe4972d268d0230be8257) where validation is added, unit test w.r.t same in [ClusterDataTest.java](https://github.com/apache/pulsar/pull/19965/files#diff-abc908f47297f5d5c41f2c719ff5e115cb152967207ea80644f34b486bd3f06a), rest 115 file diff is because of patching existing test cases, where brokerServiceUrl is set to satisfy the validation. Kindly requesting for a review. I am happy to discuss & do any improvisation / further work if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
