poorbarcode commented on code in PR #20006:
URL: https://github.com/apache/pulsar/pull/20006#discussion_r1156798535


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java:
##########
@@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean batchEnable, int 
maxBatchSize, Subscri
     public Transaction getTxn() throws Exception {
         return pulsarClient
                 .newTransaction()
-                .withTransactionTimeout(10, TimeUnit.SECONDS)
+                .withTransactionTimeout(10, TimeUnit.MINUTES)

Review Comment:
   Two questions:
   - Can we reduce the number of messages to send instead of increasing the 
timeout of TXN?
   - I found that the test failed due to a timeout of 30 seconds. Since we set 
10s timeout for TXN, why this transaction is not failed by transaction timeout?
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to