liangyepianzhou commented on code in PR #20006:
URL: https://github.com/apache/pulsar/pull/20006#discussion_r1161433555
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java:
##########
@@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean batchEnable, int
maxBatchSize, Subscri
public Transaction getTxn() throws Exception {
return pulsarClient
.newTransaction()
- .withTransactionTimeout(10, TimeUnit.SECONDS)
+ .withTransactionTimeout(10, TimeUnit.MINUTES)
Review Comment:
>I found that the test failed due to a timeout of 30 seconds. Since we set
10s timeout for TXN, why this transaction is not failed by transaction timeout?
@poorbarcode In the logs of the issue, it can be found that this test failed
due to the transaction timeout.
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java:
##########
@@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean batchEnable, int
maxBatchSize, Subscri
public Transaction getTxn() throws Exception {
return pulsarClient
.newTransaction()
- .withTransactionTimeout(10, TimeUnit.SECONDS)
+ .withTransactionTimeout(10, TimeUnit.MINUTES)
Review Comment:
>I found that the test failed due to a timeout of 30 seconds. Since we set
10s timeout for TXN, why this transaction is not failed by transaction timeout?
@poorbarcode In the logs of the issue, it can be found that this test failed
due to the transaction timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
