[GitHub] [pulsar] BewareMyPower commented on pull request #20037: [fix][broker] Check replication cluster before starting the replicator

Thu, 06 Apr 2023 20:31:53 -0700 


BewareMyPower commented on PR #20037:
URL: https://github.com/apache/pulsar/pull/20037#issuecomment-1499894825

   Before this patch:
   
![20230407103236](https://user-images.githubusercontent.com/18204803/230535003-8bc211bf-c9c5-4e57-b49f-03f566045eab.jpg)
   
   After this patch:
   
![20230407111940](https://user-images.githubusercontent.com/18204803/230535014-1cf5c225-9458-4344-843c-0e81bbcaf4d7.jpg)
   
   Example logs of updating replication clusters:
   
   ```
   2023-04-07T10:11:27,615 - INFO  - [pulsar-3575-5:BrokerService@2361] - 
[prop/ns-abc] updating with Policies(auth_policies=AuthPoliciesImpl(..., 
replication_clusters=[remote]
   2023-04-07T10:11:27,619 - INFO  - [pulsar-3575-4:BrokerService@2361] - 
[prop/ns-abc] updating with Policies(auth_policies=AuthPoliciesImpl(..., 
replication_clusters=[],
   ```
   
   We can see the interval is only 4 milliseconds but they happened in 
different threads (`pulsar-3575-5` and `pulsar-3575-4`). Sometimes the 2nd 
update might happen first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to