[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20037: [fix][test] Fix flaky testCreateTopicWithZombieReplicatorCursor

Mon, 10 Apr 2023 21:13:37 -0700 


BewareMyPower commented on code in PR #20037:
URL: https://github.com/apache/pulsar/pull/20037#discussion_r1162281071


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1542,7 +1542,13 @@ public CompletableFuture<Void> checkReplication() {
                 continue;
             }
             if (!replicators.containsKey(cluster)) {
-                futures.add(startReplicator(cluster));
+                
futures.add(checkReplicationCluster(cluster).thenCompose(clusterExists -> {

Review Comment:
   Yes, it's not related to the flaky test. I've reverted it and changed the PR 
description. The tests could still pass after that.
   
![image](https://user-images.githubusercontent.com/18204803/231054376-4422ff95-8d92-4d4b-8cae-ffe7b1d2a6da.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to