cbornet commented on code in PR #20000:
URL: https://github.com/apache/pulsar/pull/20000#discussion_r1162924689
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java:
##########
@@ -682,23 +689,12 @@ protected void testExclamationFunction(Runtime runtime,
admin.topics().createNonPartitionedTopic(inputTopicName);
admin.topics().createNonPartitionedTopic(outputTopicName);
}
- if (isTopicPattern) {
- @Cleanup PulsarClient client = PulsarClient.builder()
- .serviceUrl(pulsarCluster.getPlainTextServiceUrl())
- .build();
-
- @Cleanup Consumer<?> consumer1 = client.newConsumer(schema)
- .topic(inputTopicName + "1")
- .subscriptionType(SubscriptionType.Exclusive)
- .subscriptionName("test-sub")
- .subscribe();
-
- @Cleanup Consumer<?> consumer2 = client.newConsumer(schema)
- .topic(inputTopicName + "2")
- .subscriptionType(SubscriptionType.Exclusive)
- .subscriptionName("test-sub")
- .subscribe();
- inputTopicName = inputTopicName + ".*";
+ if (isTopicPattern || multipleInput) {
+ if (isTopicPattern) {
+ inputTopicName = inputTopicName + ".*";
+ } else {
+ inputTopicName = inputTopicName + "1," + inputTopicName + "2";
+ }
}
Review Comment:
```suggestion
if (isTopicPattern) {
inputTopicName = inputTopicName + ".*";
} else if (multipleInput) {
inputTopicName = inputTopicName + "1," + inputTopicName + "2";
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
