BewareMyPower commented on code in PR #19414: URL: https://github.com/apache/pulsar/pull/19414#discussion_r1163505120
########## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/MessageIdAdv.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.api; + +import java.util.BitSet; + +/** + * The {@link MessageId} interface provided for advanced users. + * <p> + * All built-in MessageId implementations should be able to be cast to MessageIdAdv. + * </p> + */ +public interface MessageIdAdv extends MessageId { + + /** + * Get the ledger ID. + * + * @return the ledger ID + */ + long getLedgerId(); Review Comment: This proposal has been discussed and modified into the current version of this PR in https://lists.apache.org/thread/25rzflmkfmvxhf3my0ombnbpv7bvgy32 and received 3 binding +1s and 2 non-binding +1s in https://lists.apache.org/thread/kmjq6lf1f11mf6qb8onhnlr17n27fcv4. The PIP is here: https://github.com/apache/pulsar/issues/18950 As I've explained in the PIP: > These details might be not much useful to **application users**, but they are important to developers of Pulsar and its ecosystems. > It will be difficult in future to support this API if storage layer will not be bookie or bookie API will be changed. Currently `MessageId` is still exposed to users, which does not expose these internal details. The new `MessageIdAdv` interface is only used for covenience. Users should write the following code after this PR: ```java MessageIdAdv msgIdAdv = (MessageIdAdv) msgId; if (msgIdAdv != null) { // Get the ledger id, entry id directly } else { // Handle the case when the storage layer might change in future } ``` Before this PR, there is much code like: ```java MessageIdImpl impl = (MessageIdImpl) msgId; if (impl != null) { // Check if msgId is another implementation... } else { // ... } ``` You can also see these code references in the changes of this PR. If you're going to revert this PIP, please at least start the discussion in the mail list to hear more voices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
