BewareMyPower commented on code in PR #249:
URL: https://github.com/apache/pulsar-client-cpp/pull/249#discussion_r1166655369
##########
.github/workflows/ci-pr-validation.yaml:
##########
@@ -93,6 +93,14 @@ jobs:
- name: Build
run: make -j8
+ - name: Run OAuth2 tests
+ run: |
+ docker compose -f tests/oauth2/docker-compose.yml up -d
Review Comment:
I don't think so. Because the set up phase has conflict with the default
standalone (the JWT authn provider cannot support multiple public keys), so we
have to set up another cluster or standalone for tests.
So we have to set up 3 standalones with different ports now. Ideally, we
should not keep so many clusters running at the same time.
Currently, the `pulsar-tests` binary is already too huge (80+ MB). Each time
a new file is added, the link time will increase. It's also better to split the
whole binary into multiple binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
