shibd commented on code in PR #249:
URL: https://github.com/apache/pulsar-client-cpp/pull/249#discussion_r1166667184
##########
.github/workflows/ci-pr-validation.yaml:
##########
@@ -93,6 +93,14 @@ jobs:
- name: Build
run: make -j8
+ - name: Run OAuth2 tests
+ run: |
+ docker compose -f tests/oauth2/docker-compose.yml up -d
Review Comment:
> So we have to set up 3 standalones with different ports now. Ideally, we
should not keep so many clusters running at the same time.
Make sense to me. But, I'm worried that this is too unfriendly to other
developers.
Maybe we should add scripts to run all unit tests in the future:
run_test.sh
```
1. /pulsar-test-service-start.sh
2. Run common tests.
3. ./pulsar-test-service-stop.sh
4. start-mim-test-broker.sh
5. Run `HostNameValidation` relate test
6. stop-mim-test-broker.sh
7. start-oauth2-broker.sh
8. run oauth2 relate test
9. stop-mim-test-broker.sh
10. Run other special tests
```
I wouldn't block this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
