lifepuzzlefun commented on code in PR #20086:
URL: https://github.com/apache/pulsar/pull/20086#discussion_r1166912389
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##########
@@ -567,26 +574,19 @@ public synchronized NavigableSet<PositionImpl>
getScheduledMessages(int maxMessa
log.debug("[{}] Loading next bucket snapshot segment,
bucketKey: {}, nextSegmentEntryId: {}",
dispatcher.getName(), bucket.bucketKey(),
preSegmentEntryId + 1);
}
- // All message of current snapshot segment are scheduled, load
next snapshot segment
- // TODO make it asynchronous and not blocking this process
- try {
- boolean createFutureDone =
bucket.getSnapshotCreateFuture().orElse(NULL_LONG_PROMISE).isDone();
-
- if (!createFutureDone) {
- log.info("[{}] Skip load to wait for bucket snapshot
create finish, bucketKey:{}",
- dispatcher.getName(), bucket.bucketKey());
- break;
- }
-
- if (bucket.currentSegmentEntryId ==
bucket.lastSegmentEntryId) {
-
immutableBuckets.asMapOfRanges().remove(Range.closed(bucket.startLedgerId,
bucket.endLedgerId));
- bucket.asyncDeleteBucketSnapshot(stats);
- continue;
- }
+ boolean createFutureDone =
bucket.getSnapshotCreateFuture().orElse(NULL_LONG_PROMISE).isDone();
+ if (!createFutureDone) {
+ log.info("[{}] Skip load to wait for bucket snapshot
create finish, bucketKey:{}",
+ dispatcher.getName(), bucket.bucketKey());
+ break;
+ }
- long loadStartTime = System.currentTimeMillis();
-
stats.recordTriggerEvent(BucketDelayedMessageIndexStats.Type.load);
-
bucket.asyncLoadNextBucketSnapshotEntry().thenAccept(indexList -> {
+ long loadStartTime = System.currentTimeMillis();
+
stats.recordTriggerEvent(BucketDelayedMessageIndexStats.Type.load);
+ CompletableFuture<Void> loadFuture = pendingLoad =
bucket.asyncLoadNextBucketSnapshotEntry()
Review Comment:
can this line split into multi line ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
