lifepuzzlefun commented on code in PR #20086:
URL: https://github.com/apache/pulsar/pull/20086#discussion_r1167717510
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##########
@@ -527,17 +528,22 @@ protected long nextDeliveryTime() {
}
@Override
- public synchronized long getNumberOfDelayedMessages() {
+ public long getNumberOfDelayedMessages() {
return numberDelayedMessages;
}
@Override
- public synchronized long getBufferMemoryUsage() {
+ public long getBufferMemoryUsage() {
return this.lastMutableBucket.getBufferMemoryUsage() +
sharedBucketPriorityQueue.bytesCapacity();
}
@Override
public synchronized NavigableSet<PositionImpl> getScheduledMessages(int
maxMessages) {
+ if (!checkPendingOpDone()) {
Review Comment:
agree. hope to see PIP-195 in 3.0.0 : - ）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
