poorbarcode commented on code in PR #20128:
URL: https://github.com/apache/pulsar/pull/20128#discussion_r1170768645
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java:
##########
@@ -1756,4 +1763,93 @@ public void testReplicatorProducerNotExceed() throws
Exception {
Assert.assertThrows(PulsarClientException.ProducerBusyException.class,
() -> new MessageProducer(url2, dest2));
}
+
+ @Test
+ public void testDiscontinuousMessages() throws Exception {
Review Comment:
Hi @codelipenghui
> What kind of exceptions will happen to the producer? IMO, we should use
infinite publish timeout, if the exception is not publish timeout, it should
not be a retriable exception. We should stop the replication.
My description of the scene wasn't good, it is not an `exception` for
sending messages. Now there are two scenarios:
- the schema of messages is loading. see Code-1 below
- something wrong when processing `replicateEntries`. see Code-2 below
#### Code-1
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java#L160-L179
#### Code-2
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java#L190-L192
I opened a comment list to easily track the context(^_^).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
