codelipenghui commented on code in PR #20128:
URL: https://github.com/apache/pulsar/pull/20128#discussion_r1171211658


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java:
##########
@@ -1756,4 +1763,93 @@ public void testReplicatorProducerNotExceed() throws 
Exception {
 
         Assert.assertThrows(PulsarClientException.ProducerBusyException.class, 
() -> new MessageProducer(url2, dest2));
     }
+
+    @Test
+    public void testDiscontinuousMessages() throws Exception {

Review Comment:
   > If something makes the variable lastSent to a wrong value, it can be 
solved by unload topic
   
   @poorbarcode I mean if we don't apply this fix but try to "close the 
replicator -> unload the topic" if the replicator reaches 
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java#L190-L192,
 is it able to fix the issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to