RobertIndie commented on code in PR #257:
URL: https://github.com/apache/pulsar-client-cpp/pull/257#discussion_r1177607224


##########
include/pulsar/Message.h:
##########
@@ -176,8 +176,16 @@ class PULSAR_PUBLIC Message {
      */
     bool hasSchemaVersion() const;
 
+    /**
+     * Get the schema version.
+     *
+     * @return the the schema version on success or -1 if the message does not 
have the schema version
+     */
+    int64_t getLongSchemaVersion() const;
+
     /**
      * Get the schema version
+     * @deprecated Use getLongSchemaVersion instead

Review Comment:
   It seems that we can also do it on the Java client. If we want to replace 
this public API, it's better to propose a PIP and change the Java client side 
first. I think we need to keep the API as consistent as possible with the Java 
client. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to