BewareMyPower commented on code in PR #257:
URL: https://github.com/apache/pulsar-client-cpp/pull/257#discussion_r1178552636


##########
include/pulsar/Client.h:
##########
@@ -404,6 +404,19 @@ class PULSAR_PUBLIC Client {
      */
     uint64_t getNumberOfConsumers();
 
+    /**
+     * Asynchronously get the SchemaInfo of a topic and a specific version.
+     *
+     * @topic the topic name
+     * @version the schema version byte array, see 
Message::getLongSchemaVersion.
+     * @callback the callback that is triggered when the SchemaInfo is 
retrieved successfully or not.
+     *
+     * NOTE: If there is no schema registered or the given version does not 
exist, a SchemaInfo whose type is

Review Comment:
   I won't add a new `Result`. The server side returns a `TopicNotFound` error. 
https://github.com/apache/pulsar/blob/f7c0b3c49c9ad8c28d0b00aa30d727850eb8bc04/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java#L999
   
   So I use `ResultTopicNotFound` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to