poorbarcode commented on PR #20335:
URL: https://github.com/apache/pulsar/pull/20335#issuecomment-1558424058

   @lhotari 
   
   > Is this PR an optimization or a bug fix?
   
   I think it should be called a fix.
   
   > just curious to know if the logic that was removed in this PR was causing 
problems. 
   
   If there have two consumers `[c1, c2]` on the same subscription, and there 
have some messages in the `Replay Queue`, and the `c1` was stuck by the client 
and its `permits` came to `0`, the consumer `c2` will not receive any messages 
in the `Replay Queue`, it caused by the `nextStuckConsumers` is not 
empty(`c1`), then Dispatcher will try to read new messages, but there are no 
new messages now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to