lhotari commented on PR #20335: URL: https://github.com/apache/pulsar/pull/20335#issuecomment-1559022028
> @lhotari > > > Is this PR an optimization or a bug fix? > > I think it should be called a fix. @poorbarcode Thanks for providing these details. I added the respective label. Please also update the PR description to reflect the fact that this is a bug fix. > > > just curious to know if the logic that was removed in this PR was causing problems. > > If there have two consumers `[c1, c2]` on the same subscription, and there have some messages in the `Replay Queue`, and the `c1` was stuck by the client and its `permits` came to `0`, the consumer `c2` will not receive any messages in the `Replay Queue`, it caused by the `nextStuckConsumers` is not empty(`c1`), then Dispatcher will try to read new messages, but there are no new messages now. Do you have a way to reproduce the problem and test that the fix is effective? Would you also be able to share those details? It would be useful to improve the unit & integration tests to cover such issues. I understand that the scaffolding for such tests is limited and I'm not a great fan of excessive mocking for simulating scenarios. However, providing more context for others in the community would be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
