michaeljmarshall commented on code in PR #20370:
URL: https://github.com/apache/pulsar/pull/20370#discussion_r1202739530
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##########
@@ -213,6 +214,19 @@ public static boolean debug(ServiceConfiguration config,
Logger log) {
return config.isLoadBalancerDebugModeEnabled() || log.isDebugEnabled();
}
+ public static void createSystemTopic(PulsarService pulsar, String topic)
throws PulsarServerException {
+ try {
+ pulsar.getAdminClient().topics().createNonPartitionedTopic(topic);
+ log.info("Created topic {}.", topic);
+ } catch (PulsarAdminException.ConflictException ex) {
+ if (debug(pulsar.getConfiguration(), log)) {
+ log.info("Topic {} already exists.", topic, ex);
Review Comment:
Nit
```suggestion
log.debug("Topic {} already exists.", topic, ex);
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##########
@@ -213,6 +214,19 @@ public static boolean debug(ServiceConfiguration config,
Logger log) {
return config.isLoadBalancerDebugModeEnabled() || log.isDebugEnabled();
}
+ public static void createSystemTopic(PulsarService pulsar, String topic)
throws PulsarServerException {
Review Comment:
Nit: why is this method `public` and `static`? It seems like it should be
`private` since it is used only within an instance of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
