michaeljmarshall commented on code in PR #20370:
URL: https://github.com/apache/pulsar/pull/20370#discussion_r1203366198
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##########
@@ -213,6 +214,19 @@ public static boolean debug(ServiceConfiguration config,
Logger log) {
return config.isLoadBalancerDebugModeEnabled() || log.isDebugEnabled();
}
+ public static void createSystemTopic(PulsarService pulsar, String topic)
throws PulsarServerException {
+ try {
+ pulsar.getAdminClient().topics().createNonPartitionedTopic(topic);
Review Comment:
What are the consequences of spurious failures here. Does an error lead the
broker to need to restart?
Also, how does this work in a system where there is just one broker running
in a new cluster? I have not kept up with the load balancing work, but is there
any chance of deadlock because creating this topic early requires a leader to
already be selected? If this is covered by other documentation, definitely just
point me to it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
