poorbarcode commented on PR #20407: URL: https://github.com/apache/pulsar/pull/20407#issuecomment-1566660395
@codelipenghui > Could you please provide an example? If I understand correctly, it should be > All consumers are disconnected > There is an inflight read entry operation > A new consumer connects to the broker > If all of the 3 operations happened concurrently. The new consumer might get a chance to use the updated read position by the inflight read operation as the recently joined position? But it should use the position after rewinding. > If all of the 3 operations happened concurrently. no race condition, all executed sequentially. > Could you please provide an example? I add an example to the section Motivation > The new consumer might get a chance to use the updated read position by the inflight read operation as the recently joined position? Yes, you can see the line-165 of https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L163-L169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
