codelipenghui commented on PR #20407: URL: https://github.com/apache/pulsar/pull/20407#issuecomment-1567602582
@poorbarcode Oh, I got your point now. So, from the user's perspective, all the consumers might get stuck if the problem occurs since the messages that dispatch to consumers are before the recently joined position of all consumers. I have a question about: https://github.com/apache/pulsar/blob/a26cf3eb78858ef5638650b6dbd7dab1f76a8c61/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L563-L570 Should we also skip the message delivery for `readType == ReadType.Replay`? And the [redelivery messages](https://github.com/apache/pulsar/blob/a26cf3eb78858ef5638650b6dbd7dab1f76a8c61/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L92) should also be clear for all rewind operations? since we are going to read the messages from the next position of the mark delete position. I noticed we have cleared at https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L170 https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L209 But we have more than 2 places to rewind the cursor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
