BewareMyPower commented on code in PR #275: URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209819918
########## .gitignore: ########## @@ -83,6 +83,7 @@ Makefile cmake_install.cmake CMakeFiles CMakeCache.txt +/cmake-build-debug Review Comment: Should we change it to `./cmake-build-debug`? And CMake can specifiy an arbitrary build directory. For example, the command `cmake -B build` will create a `build` directory to contain CMake build files. Though it makes sense if `cmake-build-debug` is generated by a specific IDE by default. For example, Visual Studio creates `out/` directory as the build directory. If then, please add a comment to explain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
