RobertIndie commented on code in PR #275: URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209901730
########## .gitignore: ########## @@ -83,6 +83,8 @@ Makefile cmake_install.cmake CMakeFiles CMakeCache.txt +# cmake files generated by CLion +/cmake-build-debug Review Comment: It's better to use `/cmake-build-*` just like what JetBrains suggested: https://github.com/github/gitignore/blob/4488915eec0b3a45b5c63ead28f286819c0917de/Global/JetBrains.gitignore#L43-L44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
