JooHyukKim opened a new pull request, #20503:
URL: https://github.com/apache/pulsar/pull/20503

   Fixes #20485
   
   ### Motivation
   
   Currently, when pulsar-admin commands fail, the exit code returned is `0`. 
For example, following command
   
   ```shell
   bin/pulsar-admin sources create --source-config-file NON-EXISTENT-FILE.yaml
   ```
   
   will exit with code 0. Which will not help users' debugging.
   
   ### Modifications
   
   - `CmdSources` : `run()` to throw exceptions instead of silent-catch and 
return.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/6
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to