JooHyukKim commented on code in PR #20503:
URL: https://github.com/apache/pulsar/pull/20503#discussion_r1220681635
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java:
##########
@@ -119,7 +119,7 @@ void run() throws Exception {
System.err.println();
String chosenCommand = jcommander.getParsedCommand();
getUsageFormatter().usage(chosenCommand);
- return;
+ throw e;
Review Comment:
@mattisonchao Yes, I builted & tested a bunch. But referring to your
comment, it seems like I may have finalized with the wrong version 😅.
Will get back with a confirmed version. Thank you for pointing out,
@mattisonchao! 🙏🏼
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java:
##########
@@ -119,7 +119,7 @@ void run() throws Exception {
System.err.println();
String chosenCommand = jcommander.getParsedCommand();
getUsageFormatter().usage(chosenCommand);
- return;
+ throw e;
Review Comment:
Yes, I builted & tested a bunch. But referring to your comment, it seems
like I may have finalized with the wrong version 😅.
Will get back with a confirmed version. Thank you for pointing out,
@mattisonchao! 🙏🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
