lhotari commented on code in PR #20498:
URL: https://github.com/apache/pulsar/pull/20498#discussion_r1219913003
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchSink.java:
##########
@@ -139,29 +163,35 @@ public void write(Record<GenericObject> record) throws
Exception {
} else {
elasticsearchClient.indexDocument(record, idAndDoc);
}
+ incrementCounter(METRICS_TOTAL_SUCCESS, 1);
Review Comment:
I guess the only concern about the metrics is that when bulk indexing is
used, the result is probably asynchronous. @nicoloboschi is this the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
